mtd: spear_smi: Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 3 Jun 2022 21:07:51 +0000 (23:07 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 9 Jun 2022 13:06:19 +0000 (15:06 +0200)
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so dev is never NULL.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220603210758.148493-8-u.kleine-koenig@pengutronix.de
drivers/mtd/devices/spear_smi.c

index f6febe6662dbbc67b1ce118fd23fae56f2ed0453..f58742486d3de37a9a4f04cb2034921906e0e159 100644 (file)
@@ -1048,10 +1048,6 @@ static int spear_smi_remove(struct platform_device *pdev)
        int i;
 
        dev = platform_get_drvdata(pdev);
-       if (!dev) {
-               dev_err(&pdev->dev, "dev is null\n");
-               return -ENODEV;
-       }
 
        /* clean up for all nor flash */
        for (i = 0; i < dev->num_flashes; i++) {