pinctrl: remove unnecessary unlikely()
authorIgor Stoppa <igor.stoppa@gmail.com>
Thu, 30 Aug 2018 22:34:25 +0000 (01:34 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 31 Aug 2018 09:29:12 +0000 (11:29 +0200)
WARN_ON() already contains an unlikely(), so it's not necessary to
wrap it into another.

Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/aspeed/pinctrl-aspeed.c

index aefe3c33dffd85dbdeaba81fb46e32971a720314..eb87ab774269c5ea73e63c2c12af62f9499b51a3 100644 (file)
@@ -715,7 +715,7 @@ int aspeed_pin_config_set(struct pinctrl_dev *pctldev, unsigned int offset,
 
                pmap = find_pinconf_map(param, MAP_TYPE_ARG, arg);
 
-               if (unlikely(WARN_ON(!pmap)))
+               if (WARN_ON(!pmap))
                        return -EINVAL;
 
                val = pmap->val << pconf->bit;