projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
654115e
)
dmaengine: milbeaut-xdmac: remove redundant irqsave and irqrestore in hardIRQ
author
Barry Song
<song.bao.hua@hisilicon.com>
Tue, 27 Oct 2020 21:52:47 +0000
(10:52 +1300)
committer
Vinod Koul
<vkoul@kernel.org>
Mon, 9 Nov 2020 11:55:54 +0000
(17:25 +0530)
Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled
IRQ. This patch removes the irqsave and irqstore to save some instruction
cycles.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link:
https://lore.kernel.org/r/20201027215252.25820-6-song.bao.hua@hisilicon.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/milbeaut-xdmac.c
patch
|
blob
|
history
diff --git
a/drivers/dma/milbeaut-xdmac.c
b/drivers/dma/milbeaut-xdmac.c
index 85a597228fb04bb89bcc0500092ed41c0059f196..584c931e807af3a824a1bd0adefec70195c7e6bc 100644
(file)
--- a/
drivers/dma/milbeaut-xdmac.c
+++ b/
drivers/dma/milbeaut-xdmac.c
@@
-160,10
+160,9
@@
static irqreturn_t milbeaut_xdmac_interrupt(int irq, void *dev_id)
{
struct milbeaut_xdmac_chan *mc = dev_id;
struct milbeaut_xdmac_desc *md;
- unsigned long flags;
u32 val;
- spin_lock
_irqsave(&mc->vc.lock, flags
);
+ spin_lock
(&mc->vc.lock
);
/* Ack and Stop */
val = FIELD_PREP(M10V_XDDSD_IS_MASK, 0x0);
@@
-177,7
+176,7
@@
static irqreturn_t milbeaut_xdmac_interrupt(int irq, void *dev_id)
milbeaut_xdmac_start(mc);
out:
- spin_unlock
_irqrestore(&mc->vc.lock, flags
);
+ spin_unlock
(&mc->vc.lock
);
return IRQ_HANDLED;
}