crypto: octeontx2 - fix missing unlock

Add the missing unlock before return from error path.

Fixes: 4363f3d3ce8f ("crypto: octeontx2 - add synchronization between mailbox accesses")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c b/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c
index 17a9dd20c8c355d5d01035f3859c348d76473e64..a402ccfac55770c63113e036013d0daf6b53cebf 100644 (file)
--- a/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c
@@ -143,8 +143,10 @@ static void cptpf_flr_wq_handler(struct work_struct *work)
        mutex_lock(&pf->lock);
        req = otx2_mbox_alloc_msg_rsp(mbox, 0, sizeof(*req),
                                      sizeof(struct msg_rsp));
-       if (!req)
+       if (!req) {
+               mutex_unlock(&pf->lock);
                return;
+       }
 
        req->sig = OTX2_MBOX_REQ_SIG;
        req->id = MBOX_MSG_VF_FLR;

diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c b/drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c
index fee758b86d29f5c8cfdfa5533217f02fa6726dda..dee0aa60b698524ae2d672affdc8e6eba8ceca35 100644 (file)
--- a/drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c
@@ -20,8 +20,10 @@ static int forward_to_af(struct otx2_cptpf_dev *cptpf,
 
        mutex_lock(&cptpf->lock);
        msg = otx2_mbox_alloc_msg(&cptpf->afpf_mbox, 0, size);
-       if (msg == NULL)
+       if (msg == NULL) {
+               mutex_unlock(&cptpf->lock);
                return -ENOMEM;
+       }
 
        memcpy((uint8_t *)msg + sizeof(struct mbox_msghdr),
               (uint8_t *)req + sizeof(struct mbox_msghdr), size);