ivshmem: Mark questionable socket type test FIXME
authorMarkus Armbruster <armbru@redhat.com>
Tue, 24 Nov 2015 17:06:28 +0000 (18:06 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 25 Nov 2015 09:24:15 +0000 (10:24 +0100)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
hw/misc/ivshmem.c

index 83d7bd3e5f0d38d714ce2393b32eaca0a7da09f4..edb22704c7ab4c3927124b07d1ead93467b0c58c 100644 (file)
@@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
         memory_region_add_subregion(&s->bar, 0, mr);
         pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
     } else if (s->server_chr != NULL) {
+        /* FIXME do not rely on what chr drivers put into filename */
         if (strncmp(s->server_chr->filename, "unix:", 5)) {
             error_setg(errp, "chardev is not a unix client socket");
             return;