ath11k: Fix possible memleak in ath11k_qmi_init_service
authorWang Yufen <wangyufen@huawei.com>
Mon, 20 Jul 2020 09:36:44 +0000 (17:36 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 18 Aug 2020 09:51:25 +0000 (12:51 +0300)
When qmi_add_lookup fail, we should destroy the workqueue

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1595237804-66297-1-git-send-email-wangyufen@huawei.com
drivers/net/wireless/ath/ath11k/qmi.c

index b81897131f0a6f59d4762863dab131a422406bd7..91134510364c2be50ae345415d70ffa3f8272e30 100644 (file)
@@ -2648,6 +2648,7 @@ int ath11k_qmi_init_service(struct ath11k_base *ab)
                             ab->qmi.service_ins_id);
        if (ret < 0) {
                ath11k_warn(ab, "failed to add qmi lookup\n");
+               destroy_workqueue(ab->qmi.event_wq);
                return ret;
        }