scsi: ufs: ufs-mediatek: Check link status after exiting hibern8
authorPeter Wang <peter.wang@mediatek.com>
Thu, 21 Dec 2023 11:04:14 +0000 (19:04 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 24 Jan 2024 02:06:05 +0000 (21:06 -0500)
To prevent SSU(Active) error, check link status after exiting hibern8.  If
link is not VS_LINK_UP, return error and do ufshcd_link_recovery.

Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Link: https://lore.kernel.org/r/20231221110416.16176-2-peter.wang@mediatek.com
Reviewed-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-mediatek.c

index f43eb945e011ed5b73499b5fb7effa22dae9ff3a..dcccb63f74b9443db856db0ecabac1666efacb94 100644 (file)
@@ -1189,11 +1189,18 @@ static int ufs_mtk_link_set_hpm(struct ufs_hba *hba)
                return err;
 
        err = ufshcd_uic_hibern8_exit(hba);
-       if (!err)
-               ufshcd_set_link_active(hba);
-       else
+       if (err)
                return err;
 
+       /* Check link state to make sure exit h8 success */
+       ufs_mtk_wait_idle_state(hba, 5);
+       err = ufs_mtk_wait_link_state(hba, VS_LINK_UP, 100);
+       if (err) {
+               dev_warn(hba->dev, "exit h8 state fail, err=%d\n", err);
+               return err;
+       }
+       ufshcd_set_link_active(hba);
+
        if (!hba->mcq_enabled) {
                err = ufshcd_make_hba_operational(hba);
        } else {