hypfs: don't bother with d_delete()
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 27 Jul 2019 20:10:56 +0000 (16:10 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 3 Sep 2019 13:30:54 +0000 (09:30 -0400)
If that's not the last reference, d_delete() will do d_drop().
If it is, dput() immediately after it will unhash the sucker
anyway, since ->d_delete() the method is always_delete_dentry().

IOW, there's no point trying to turn it into a negative hashed
dentry - it won't stick around anyway.  Just d_drop() it and be
done with that.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/s390/hypfs/inode.c

index ccad1398abd406eba3298cc85bec320161443566..a4418fc425b8d23d46128d8477f7af56e64bc2ad 100644 (file)
@@ -76,7 +76,7 @@ static void hypfs_remove(struct dentry *dentry)
                else
                        simple_unlink(d_inode(parent), dentry);
        }
-       d_delete(dentry);
+       d_drop(dentry);
        dput(dentry);
        inode_unlock(d_inode(parent));
 }