projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4ee8225
)
gpio: max77620: Fix missing release of interrupt
author
Dmitry Osipenko
<digetx@gmail.com>
Thu, 9 Jul 2020 17:11:59 +0000
(20:11 +0300)
committer
Linus Walleij
<linus.walleij@linaro.org>
Thu, 16 Jul 2020 08:50:40 +0000
(10:50 +0200)
The requested interrupt is never released by the driver. Fix this by
using the resource-managed variant of request_threaded_irq().
Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: <stable@vger.kernel.org> # 5.5+
Link:
https://lore.kernel.org/r/20200709171203.12950-3-digetx@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-max77620.c
patch
|
blob
|
history
diff --git
a/drivers/gpio/gpio-max77620.c
b/drivers/gpio/gpio-max77620.c
index 4c0c9ec2587d34e62ed595a67ac89a958cca6860..7f7e8d4bf0d3a3bbb411a97ffbc0bf7e94181b62 100644
(file)
--- a/
drivers/gpio/gpio-max77620.c
+++ b/
drivers/gpio/gpio-max77620.c
@@
-305,8
+305,9
@@
static int max77620_gpio_probe(struct platform_device *pdev)
gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip,
0, handle_edge_irq, IRQ_TYPE_NONE);
- ret = request_threaded_irq(gpio_irq, NULL, max77620_gpio_irqhandler,
- IRQF_ONESHOT, "max77620-gpio", mgpio);
+ ret = devm_request_threaded_irq(&pdev->dev, gpio_irq, NULL,
+ max77620_gpio_irqhandler, IRQF_ONESHOT,
+ "max77620-gpio", mgpio);
if (ret < 0) {
dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret);
return ret;