media: i2c: ccs: replace snprintf in show functions with sysfs_emit
authorQing Wang <wangqing@vivo.com>
Mon, 18 Oct 2021 08:00:36 +0000 (09:00 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 15 Nov 2021 08:11:34 +0000 (08:11 +0000)
show() should not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/media/i2c/ccs/ccs-core.c:3761: WARNING: use scnprintf or sprintf.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ccs/ccs-core.c

index 5363f3bcafe3df14a8b2b2bd86cdcec138bd3ab5..9158d3ce45c04b666697ceadc57b8f3f6bbd9caa 100644 (file)
@@ -2758,13 +2758,13 @@ ident_show(struct device *dev, struct device_attribute *attr, char *buf)
        struct ccs_module_info *minfo = &sensor->minfo;
 
        if (minfo->mipi_manufacturer_id)
-               return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n",
-                               minfo->mipi_manufacturer_id, minfo->model_id,
-                               minfo->revision_number) + 1;
+               return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
+                                   minfo->mipi_manufacturer_id, minfo->model_id,
+                                   minfo->revision_number) + 1;
        else
-               return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n",
-                               minfo->smia_manufacturer_id, minfo->model_id,
-                               minfo->revision_number) + 1;
+               return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
+                                   minfo->smia_manufacturer_id, minfo->model_id,
+                                   minfo->revision_number) + 1;
 }
 static DEVICE_ATTR_RO(ident);