arm64: dts: qcom: msm8998: Make regulator voltages multiple of step-size
authorMarijn Suijten <marijn.suijten@somainline.org>
Sat, 7 May 2022 15:36:27 +0000 (17:36 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Sat, 16 Jul 2022 15:18:14 +0000 (10:18 -0500)
These voltages are not a multiple of the given step-size 8000 (with base
voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and
l22 failing to validate and in turn not probing the rpm-pm8998-regulator
driver:

    l18: unsupportable voltage constraints 2856000-2848000uV
    qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22

Round the voltages down for the sake of erring on the safe side, leaving
a comment in place to document this discrepancy wrt downstream sources.

Fixes: 390883af89d2 ("arm64: dts: qcom: msm8998: Introduce support for Sony Yoshino platform")
Reported-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220507153627.1478268-1-marijn.suijten@somainline.org
arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts

index 4a1f98a210319d38c1de20939cb1914f0b6583ec..c21333aa73c2990df39838f736485884b754efc9 100644 (file)
 };
 
 &vreg_l18a_2p85 {
-       regulator-min-microvolt = <2850000>;
-       regulator-max-microvolt = <2850000>;
+       /* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 */
+       regulator-min-microvolt = <2848000>;
+       regulator-max-microvolt = <2848000>;
 };
 
 &vreg_l22a_2p85 {
-       regulator-min-microvolt = <2700000>;
-       regulator-max-microvolt = <2700000>;
+       /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */
+       regulator-min-microvolt = <2696000>;
+       regulator-max-microvolt = <2696000>;
 };