media: rockchip: rga: use macros for testing buffer type

Use the provided V4L2_TYPE_IS_{OUTPUT,CAPTURE} macros to check if the
buffer or queue is OUTPUT or CAPTURE. The macros work also work for the
_MPLANE buffer and queue types and make it easier to switch to the
multi-planar API.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
index f5d0d87cce22a40ebf90aa88808519e45f6db701..91be87e01dab8e7f8579b966bd2186f823f53f1d 100644 (file)
--- a/drivers/media/platform/rockchip/rga/rga.c
+++ b/drivers/media/platform/rockchip/rga/rga.c
@@ -344,14 +344,11 @@ static struct rga_frame def_frame = {
 
 struct rga_frame *rga_get_frame(struct rga_ctx *ctx, enum v4l2_buf_type type)
 {
-       switch (type) {
-       case V4L2_BUF_TYPE_VIDEO_OUTPUT:
+       if (V4L2_TYPE_IS_OUTPUT(type))
                return &ctx->in;
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE:
+       if (V4L2_TYPE_IS_CAPTURE(type))
                return &ctx->out;
-       default:
-               return ERR_PTR(-EINVAL);
-       }
+       return ERR_PTR(-EINVAL);
 }
 
 static int rga_open(struct file *file)
@@ -559,21 +556,21 @@ static int vidioc_g_selection(struct file *file, void *prv,
        switch (s->target) {
        case V4L2_SEL_TGT_COMPOSE_DEFAULT:
        case V4L2_SEL_TGT_COMPOSE_BOUNDS:
-               if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+               if (!V4L2_TYPE_IS_CAPTURE(s->type))
                        return -EINVAL;
                break;
        case V4L2_SEL_TGT_CROP_DEFAULT:
        case V4L2_SEL_TGT_CROP_BOUNDS:
-               if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
+               if (!V4L2_TYPE_IS_OUTPUT(s->type))
                        return -EINVAL;
                break;
        case V4L2_SEL_TGT_COMPOSE:
-               if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+               if (!V4L2_TYPE_IS_CAPTURE(s->type))
                        return -EINVAL;
                use_frame = true;
                break;
        case V4L2_SEL_TGT_CROP:
-               if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
+               if (!V4L2_TYPE_IS_OUTPUT(s->type))
                        return -EINVAL;
                use_frame = true;
                break;
@@ -611,7 +608,7 @@ static int vidioc_s_selection(struct file *file, void *prv,
                 * COMPOSE target is only valid for capture buffer type, return
                 * error for output buffer type
                 */
-               if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+               if (!V4L2_TYPE_IS_CAPTURE(s->type))
                        return -EINVAL;
                break;
        case V4L2_SEL_TGT_CROP:
@@ -619,7 +616,7 @@ static int vidioc_s_selection(struct file *file, void *prv,
                 * CROP target is only valid for output buffer type, return
                 * error for capture buffer type
                 */
-               if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
+               if (!V4L2_TYPE_IS_OUTPUT(s->type))
                        return -EINVAL;
                break;
        /*