serial: imx: refine local variables in rxint()
authorSergey Organov <sorganov@gmail.com>
Wed, 1 Feb 2023 14:27:00 +0000 (17:27 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Feb 2023 12:12:07 +0000 (13:12 +0100)
The 'rx' is chip register, similar to 'usr2', so let it be of 'u32' type as
well.

Move 'flg' to be FIFO read loop local as it's not used outside.

Signed-off-by: Sergey Organov <sorganov@gmail.com>
Link: https://lore.kernel.org/r/20230201142700.4346-8-sorganov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/imx.c

index a662f48a214652b65d345a870128c5e7023a8411..e2a89b9206375e684de83a5767d27299f8f88696 100644 (file)
@@ -890,9 +890,8 @@ static void imx_uart_check_flood(struct imx_port *sport, u32 usr2)
 static irqreturn_t __imx_uart_rxint(int irq, void *dev_id)
 {
        struct imx_port *sport = dev_id;
-       unsigned int rx, flg;
        struct tty_port *port = &sport->port.state->port;
-       u32 usr2;
+       u32 usr2, rx;
 
        /* If we received something, check for 0xff flood */
        usr2 = imx_uart_readl(sport, USR2);
@@ -900,7 +899,7 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id)
                imx_uart_check_flood(sport, usr2);
 
        while ((rx = imx_uart_readl(sport, URXD0)) & URXD_CHARRDY) {
-               flg = TTY_NORMAL;
+               unsigned int flg = TTY_NORMAL;
                sport->port.icount.rx++;
 
                if (unlikely(rx & URXD_ERR)) {