soc: ti: knav_dma: Use proper enum in pktdma_init_chan
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 30 Jan 2019 18:21:44 +0000 (10:21 -0800)
committerSantosh Shilimkar <santosh.shilimkar@oracle.com>
Wed, 30 Jan 2019 18:22:17 +0000 (10:22 -0800)
Clang warns when one enumerated type is implicitly converted to another:

drivers/soc/ti/knav_dma.c:601:20: warning: implicit conversion from
enumeration type 'enum dma_data_direction' to different enumeration type
'enum dma_transfer_direction' [-Wenum-conversion]
        chan->direction = DMA_NONE;
                        ~ ^~~~~~~~
1 warning generated.

While DMA_NONE and DMA_TRANS_NONE have different values, there is no
functional change because direction is never checked against DMA_NONE,
only against DMA_MEM_TO_DEV and DMA_DEV_TO_MEM.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
drivers/soc/ti/knav_dma.c

index e05ab16d9a9e3c10224e93745f57f1d477616a22..6285cd8efb21bb9798249e7db404b5aeb16c1d8e 100644 (file)
@@ -598,7 +598,7 @@ static int pktdma_init_chan(struct knav_dma_device *dma,
 
        INIT_LIST_HEAD(&chan->list);
        chan->dma       = dma;
-       chan->direction = DMA_NONE;
+       chan->direction = DMA_TRANS_NONE;
        atomic_set(&chan->ref_count, 0);
        spin_lock_init(&chan->lock);