watchdog/hpwdt: Remove redundant test.
authorJerry Hoemann <jerry.hoemann@hpe.com>
Wed, 13 Dec 2023 21:53:39 +0000 (14:53 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 17 Dec 2023 15:14:21 +0000 (16:14 +0100)
ProLiants of vintage to have an iLO 5, no longer send watchdog NMI
as an IO CHECK.  They are presented to hpwdt_pretimeout as NMI_UNKNOWN.
The preceding if statement rejects if !mynmi irrespective of value
of pretimeout making this if statement redundant.

Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231213215340.495734-3-jerry.hoemann@hpe.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/hpwdt.c

index 79ed1626d8ea11a17ba42653318e2b682d27fa37..d5c0aa3ef06961a3d0e9aeea95a24bd9744e67ed 100644 (file)
@@ -181,9 +181,6 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
        if (ulReason == NMI_UNKNOWN && !mynmi)
                return NMI_DONE;
 
-       if (ilo5 && !pretimeout && !mynmi)
-               return NMI_DONE;
-
        if (kdumptimeout < 0)
                hpwdt_stop();
        else if (kdumptimeout == 0)