drm/msm/dp: delete EV_HPD_INIT_SETUP
authorKuogee Hsieh <quic_khsieh@quicinc.com>
Fri, 1 Dec 2023 23:19:48 +0000 (15:19 -0800)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 3 Dec 2023 00:13:17 +0000 (03:13 +0300)
EV_HPD_INIT_SETUP flag is used to trigger the initialization of external
DP host controller. Since external DP host controller initialization had
been incorporated into pm_runtime_resume(), this flag became obsolete.
msm_dp_irq_postinstall() which triggers EV_HPD_INIT_SETUP event is
obsoleted accordingly.

Changes in v4:
-- reworded commit text
-- drop EV_HPD_INIT_SETUP
-- drop msm_dp_irq_postinstall()

Changes in v3:
-- drop EV_HPD_INIT_SETUP and msm_dp_irq_postinstall()

Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/570075/
Link: https://lore.kernel.org/r/1701472789-25951-7-git-send-email-quic_khsieh@quicinc.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
drivers/gpu/drm/msm/dp/dp_display.c
drivers/gpu/drm/msm/msm_drv.h

index babec724c76a5909591f3baa2c8386332858caaa..9b2efd7acc8725c72766a2059222c38331a413e6 100644 (file)
@@ -845,7 +845,6 @@ static int dpu_irq_postinstall(struct msm_kms *kms)
 {
        struct msm_drm_private *priv;
        struct dpu_kms *dpu_kms = to_dpu_kms(kms);
-       int i;
 
        if (!dpu_kms || !dpu_kms->dev)
                return -EINVAL;
@@ -854,9 +853,6 @@ static int dpu_irq_postinstall(struct msm_kms *kms)
        if (!priv)
                return -EINVAL;
 
-       for (i = 0; i < ARRAY_SIZE(priv->dp); i++)
-               msm_dp_irq_postinstall(priv->dp[i]);
-
        return 0;
 }
 
index 05143ab9c6a4395b494f6d4eb7d0e74e388e987a..50054f28e5b2f2d1608a62b47480e48d12a4a775 100644 (file)
@@ -54,7 +54,6 @@ enum {
 enum {
        EV_NO_EVENT,
        /* hpd events */
-       EV_HPD_INIT_SETUP,
        EV_HPD_PLUG_INT,
        EV_IRQ_HPD_INT,
        EV_HPD_UNPLUG_INT,
@@ -1078,8 +1077,6 @@ static int hpd_event_thread(void *data)
                spin_unlock_irqrestore(&dp_priv->event_lock, flag);
 
                switch (todo->event_id) {
-               case EV_HPD_INIT_SETUP:
-                       break;
                case EV_HPD_PLUG_INT:
                        dp_hpd_plug_handle(dp_priv, todo->data);
                        break;
@@ -1359,19 +1356,6 @@ void __exit msm_dp_unregister(void)
        platform_driver_unregister(&dp_display_driver);
 }
 
-void msm_dp_irq_postinstall(struct msm_dp *dp_display)
-{
-       struct dp_display_private *dp;
-
-       if (!dp_display)
-               return;
-
-       dp = container_of(dp_display, struct dp_display_private, dp_display);
-
-       if (!dp_display->is_edp)
-               dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 0);
-}
-
 bool msm_dp_wide_bus_available(const struct msm_dp *dp_display)
 {
        struct dp_display_private *dp;
index 628ef3e663ea49b68a7a38cc911427f52c2c0e2d..a205127ccc932f6bfd8a5a7dd56d7c0cb84da15c 100644 (file)
@@ -386,7 +386,6 @@ int __init msm_dp_register(void);
 void __exit msm_dp_unregister(void);
 int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,
                         struct drm_encoder *encoder);
-void msm_dp_irq_postinstall(struct msm_dp *dp_display);
 void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp_display);
 
 bool msm_dp_wide_bus_available(const struct msm_dp *dp_display);
@@ -406,10 +405,6 @@ static inline int msm_dp_modeset_init(struct msm_dp *dp_display,
        return -EINVAL;
 }
 
-static inline void msm_dp_irq_postinstall(struct msm_dp *dp_display)
-{
-}
-
 static inline void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp_display)
 {
 }