media: cx231xx: Add EP5_BUF_SIZE and EP5_TIMEOUT_MS macros

Define EP5_BUF_SIZE and EP5_TIMEOUT_MS macros to make the code
more readable.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Suggested-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c
index 746727ea1a4c7fa0020a7143e3d7c4ea0f35eafc..57a8b4780a7d6d1033ca1346ffdb2b2f995262d7 100644 (file)
--- a/drivers/media/usb/cx231xx/cx231xx-core.c
+++ b/drivers/media/usb/cx231xx/cx231xx-core.c
@@ -751,12 +751,12 @@ int cx231xx_ep5_bulkout(struct cx231xx *dev, u8 *firmware, u16 size)
        int ret = -ENOMEM;
        u32 *buffer;
 
-       buffer = kmemdup(firmware, 4096, GFP_KERNEL);
+       buffer = kmemdup(firmware, EP5_BUF_SIZE, GFP_KERNEL);
        if (buffer == NULL)
                return -ENOMEM;
 
        ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, 5),
-                       buffer, 4096, &actlen, 2000);
+                       buffer, EP5_BUF_SIZE, &actlen, EP5_TIMEOUT_MS);
 
        if (ret)
                dev_err(dev->dev,

diff --git a/drivers/media/usb/cx231xx/cx231xx.h b/drivers/media/usb/cx231xx/cx231xx.h
index 6929e4d97067ad493aad1d4f2e4a7927e2bced6b..74339a6a2f718436dc4c13889eef5017e630959b 100644 (file)
--- a/drivers/media/usb/cx231xx/cx231xx.h
+++ b/drivers/media/usb/cx231xx/cx231xx.h
@@ -120,6 +120,9 @@
 #define CX23417_OSC_EN   8
 #define CX23417_RESET    9
 
+#define EP5_BUF_SIZE     4096
+#define EP5_TIMEOUT_MS   2000
+
 struct cx23417_fmt {
        u32   fourcc;          /* v4l2 format id */
        int   depth;