platform/x86/amd/hsmp: Change devm_kzalloc() to devm_kcalloc()
authorSuma Hegde <suma.hegde@amd.com>
Thu, 25 Jan 2024 12:54:01 +0000 (12:54 +0000)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Wed, 31 Jan 2024 08:31:18 +0000 (10:31 +0200)
Use the standard array allocation variant of devm memory allocation
APIs.

Signed-off-by: Suma Hegde <suma.hegde@amd.com>
Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
Link: https://lore.kernel.org/r/20240125125401.597617-1-suma.hegde@amd.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/hsmp.c

index 4a12d7ab36c119fb3542b8532848e16c582f3a73..1927be901108e3c9f0b7eacadf007ad9b849688e 100644 (file)
@@ -655,8 +655,9 @@ static int hsmp_create_attr_list(struct attribute_group *attr_grp,
        struct bin_attribute **hsmp_bin_attrs;
 
        /* Null terminated list of attributes */
-       hsmp_bin_attrs = devm_kzalloc(dev, sizeof(struct bin_attribute *) *
-                                     (NUM_HSMP_ATTRS + 1), GFP_KERNEL);
+       hsmp_bin_attrs = devm_kcalloc(dev, NUM_HSMP_ATTRS + 1,
+                                     sizeof(*hsmp_bin_attrs),
+                                     GFP_KERNEL);
        if (!hsmp_bin_attrs)
                return -ENOMEM;
 
@@ -671,8 +672,9 @@ static int hsmp_create_non_acpi_sysfs_if(struct device *dev)
        struct attribute_group *attr_grp;
        u16 i;
 
-       hsmp_attr_grps = devm_kzalloc(dev, sizeof(struct attribute_group *) *
-                                     (plat_dev.num_sockets + 1), GFP_KERNEL);
+       hsmp_attr_grps = devm_kcalloc(dev, plat_dev.num_sockets + 1,
+                                     sizeof(*hsmp_attr_grps),
+                                     GFP_KERNEL);
        if (!hsmp_attr_grps)
                return -ENOMEM;
 
@@ -801,8 +803,8 @@ static int hsmp_pltdrv_probe(struct platform_device *pdev)
         * on each probe.
         */
        if (!plat_dev.is_probed) {
-               plat_dev.sock = devm_kzalloc(&pdev->dev,
-                                            (plat_dev.num_sockets * sizeof(struct hsmp_socket)),
+               plat_dev.sock = devm_kcalloc(&pdev->dev, plat_dev.num_sockets,
+                                            sizeof(*plat_dev.sock),
                                             GFP_KERNEL);
                if (!plat_dev.sock)
                        return -ENOMEM;