drm/v3d: remove _unlocked suffix in drm_gem_object_put_unlocked
authorEmil Velikov <emil.velikov@collabora.com>
Fri, 15 May 2020 09:51:12 +0000 (10:51 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Tue, 19 May 2020 21:31:35 +0000 (22:31 +0100)
Spelling out _unlocked for each and every driver is a annoying.
Especially if we consider how many drivers, do not know (or need to)
about the horror stories involving struct_mutex.

Just drop the suffix. It makes the API cleaner.

Done via the following script:

__from=drm_gem_object_put_unlocked
__to=drm_gem_object_put
for __file in $(git grep --name-only $__from); do
  sed -i  "s/$__from/$__to/g" $__file;
done

Cc: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200515095118.2743122-33-emil.l.velikov@gmail.com
drivers/gpu/drm/v3d/v3d_bo.c
drivers/gpu/drm/v3d/v3d_gem.c
drivers/gpu/drm/v3d/v3d_irq.c

index edd299ab53d8f1fce95b9ef2e9018c4ef25c1f6c..8b52cb25877c6f8b1d4eca05630187dfc18c9806 100644 (file)
@@ -185,7 +185,7 @@ int v3d_create_bo_ioctl(struct drm_device *dev, void *data,
        args->offset = bo->node.start << PAGE_SHIFT;
 
        ret = drm_gem_handle_create(file_priv, &bo->base.base, &args->handle);
-       drm_gem_object_put_unlocked(&bo->base.base);
+       drm_gem_object_put(&bo->base.base);
 
        return ret;
 }
@@ -208,7 +208,7 @@ int v3d_mmap_bo_ioctl(struct drm_device *dev, void *data,
        }
 
        args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node);
-       drm_gem_object_put_unlocked(gem_obj);
+       drm_gem_object_put(gem_obj);
 
        return 0;
 }
@@ -229,6 +229,6 @@ int v3d_get_bo_offset_ioctl(struct drm_device *dev, void *data,
 
        args->offset = bo->node.start << PAGE_SHIFT;
 
-       drm_gem_object_put_unlocked(gem_obj);
+       drm_gem_object_put(gem_obj);
        return 0;
 }
index 09a7639cf161f59fcfe34d23ebea036838801315..915f8bfdb58cad0f355b4e5c94fbf37df651309a 100644 (file)
@@ -358,7 +358,7 @@ v3d_job_free(struct kref *ref)
 
        for (i = 0; i < job->bo_count; i++) {
                if (job->bo[i])
-                       drm_gem_object_put_unlocked(job->bo[i]);
+                       drm_gem_object_put(job->bo[i]);
        }
        kvfree(job->bo);
 
@@ -384,7 +384,7 @@ v3d_render_job_free(struct kref *ref)
        struct v3d_bo *bo, *save;
 
        list_for_each_entry_safe(bo, save, &job->unref_list, unref_head) {
-               drm_gem_object_put_unlocked(&bo->base.base);
+               drm_gem_object_put(&bo->base.base);
        }
 
        v3d_job_free(ref);
index 51b65263c6571a2b088230e94c989482bd88cfcb..c88686489b88899fb3b8d8094bec02ff32b662f5 100644 (file)
@@ -72,7 +72,7 @@ v3d_overflow_mem_work(struct work_struct *work)
        V3D_CORE_WRITE(0, V3D_PTB_BPOS, obj->size);
 
 out:
-       drm_gem_object_put_unlocked(obj);
+       drm_gem_object_put(obj);
 }
 
 static irqreturn_t