media: vidtv: Fix memory leak in remove
authorEvgeny Novikov <novikov@ispras.ru>
Thu, 27 May 2021 09:26:24 +0000 (11:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:12 +0000 (19:16 +0100)
[ Upstream commit 76e21bb8be4f5f987f3006d197196fe6af63f656 ]

vidtv_bridge_remove() releases and cleans up everything except for dvb
itself. The patch adds this missed release.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/test-drivers/vidtv/vidtv_bridge.c

index 75617709c8ce2dbb23069890735b6801bb0d9efb..0f6d998d18dc0a21d258e39595eaed5dbef14e86 100644 (file)
@@ -557,6 +557,7 @@ static int vidtv_bridge_remove(struct platform_device *pdev)
        dvb_dmxdev_release(&dvb->dmx_dev);
        dvb_dmx_release(&dvb->demux);
        dvb_unregister_adapter(&dvb->adapter);
+       kfree(dvb);
        dev_info(&pdev->dev, "Successfully removed vidtv\n");
 
        return 0;