mm/slub: Remove the unneeded result variable
authorye xingchen <ye.xingchen@zte.com.cn>
Mon, 22 Aug 2022 01:38:30 +0000 (01:38 +0000)
committerVlastimil Babka <vbabka@suse.cz>
Tue, 23 Aug 2022 14:07:36 +0000 (16:07 +0200)
Return the value from attribute->store(s, buf, len) and
attribute->show(s, buf) directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
mm/slub.c

index 862dbd9af4f521fe820a9b5bdb69e7a726ba3d5d..dc59b9e8c66f6007ab84e0460aad087358fe2fd8 100644 (file)
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -5826,7 +5826,6 @@ static ssize_t slab_attr_show(struct kobject *kobj,
 {
        struct slab_attribute *attribute;
        struct kmem_cache *s;
-       int err;
 
        attribute = to_slab_attr(attr);
        s = to_slab(kobj);
@@ -5834,9 +5833,7 @@ static ssize_t slab_attr_show(struct kobject *kobj,
        if (!attribute->show)
                return -EIO;
 
-       err = attribute->show(s, buf);
-
-       return err;
+       return attribute->show(s, buf);
 }
 
 static ssize_t slab_attr_store(struct kobject *kobj,
@@ -5845,7 +5842,6 @@ static ssize_t slab_attr_store(struct kobject *kobj,
 {
        struct slab_attribute *attribute;
        struct kmem_cache *s;
-       int err;
 
        attribute = to_slab_attr(attr);
        s = to_slab(kobj);
@@ -5853,8 +5849,7 @@ static ssize_t slab_attr_store(struct kobject *kobj,
        if (!attribute->store)
                return -EIO;
 
-       err = attribute->store(s, buf, len);
-       return err;
+       return attribute->store(s, buf, len);
 }
 
 static void kmem_cache_release(struct kobject *k)