pwm: lp3943: Fix duty calculation in case period was clamped
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 8 Apr 2022 15:22:38 +0000 (17:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:36:04 +0000 (18:36 +0200)
[ Upstream commit 5e3b07ca5cc78cd4a987e78446849e41288d87cb ]

The hardware only supports periods <= 1.6 ms and if a bigger period is
requested it is clamped to 1.6 ms. In this case duty_cycle might be bigger
than 1.6 ms and then the duty cycle register is written with a value
bigger than LP3943_MAX_DUTY. So clamp duty_cycle accordingly.

Fixes: af66b3c0934e ("pwm: Add LP3943 PWM driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-lp3943.c

index ea17d446a62767fc2cccff8f2de48b2dfd2479df..2bd04ecb508cf3cae9073482f1e41057a3e7823f 100644 (file)
@@ -125,6 +125,7 @@ static int lp3943_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
        if (err)
                return err;
 
+       duty_ns = min(duty_ns, period_ns);
        val = (u8)(duty_ns * LP3943_MAX_DUTY / period_ns);
 
        return lp3943_write_byte(lp3943, reg_duty, val);