ata: pata_parport: Introduce module_pata_parport_driver macro

Introduce module_pata_parport_driver macro and use it in protocol
drivers to reduce boilerplate code. Remove paride_(un)register
compatibility defines.

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Ondrej Zary <linux@zary.sk>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

diff --git a/drivers/ata/pata_parport/aten.c b/drivers/ata/pata_parport/aten.c
index b66508bedbd0236f8b609e29abf58d3a80dd4aed..9e6098f90162a66be5866384852459c3804339db 100644 (file)
--- a/drivers/ata/pata_parport/aten.c
+++ b/drivers/ata/pata_parport/aten.c
@@ -147,16 +147,5 @@ static struct pi_protocol aten = {
        .log_adapter    = aten_log_adapter,
 };
 
-static int __init aten_init(void)
-{
-       return paride_register(&aten);
-}
-
-static void __exit aten_exit(void)
-{
-       paride_unregister( &aten );
-}
-
 MODULE_LICENSE("GPL");
-module_init(aten_init)
-module_exit(aten_exit)
+module_pata_parport_driver(aten);

diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
index 5fb3cf9ba11dc76bb2382bf52d96d89ec2585b9b..b9174cf8863c20f64e595f025b1f04b7ff179acf 100644 (file)
--- a/drivers/ata/pata_parport/bpck.c
+++ b/drivers/ata/pata_parport/bpck.c
@@ -462,16 +462,5 @@ static struct pi_protocol bpck = {
        .log_adapter    = bpck_log_adapter,
 };
 
-static int __init bpck_init(void)
-{
-       return paride_register(&bpck);
-}
-
-static void __exit bpck_exit(void)
-{
-       paride_unregister(&bpck);
-}
-
 MODULE_LICENSE("GPL");
-module_init(bpck_init)
-module_exit(bpck_exit)
+module_pata_parport_driver(bpck);

diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
index 3b3a40e48b2121b4c349abab282011242fc0d91d..3c358e66db257a77766aa64221c3ab7664e5dee1 100644 (file)
--- a/drivers/ata/pata_parport/bpck6.c
+++ b/drivers/ata/pata_parport/bpck6.c
@@ -245,19 +245,8 @@ static struct pi_protocol bpck6 = {
        .release_proto  = bpck6_release_proto,
 };
 
-static int __init bpck6_init(void)
-{
-       return paride_register(&bpck6);
-}
-
-static void __exit bpck6_exit(void)
-{
-       paride_unregister(&bpck6);
-}
-
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Micro Solutions Inc.");
 MODULE_DESCRIPTION("BACKPACK Protocol module, compatible with PARIDE");
 module_param(verbose, bool, 0644);
-module_init(bpck6_init)
-module_exit(bpck6_exit)
+module_pata_parport_driver(bpck6);

diff --git a/drivers/ata/pata_parport/comm.c b/drivers/ata/pata_parport/comm.c
index 11ed9fb57744c5569841f314f25333b643e380fe..47f0fbccc3aa0522cc2b5006924c72ac727df51d 100644 (file)
--- a/drivers/ata/pata_parport/comm.c
+++ b/drivers/ata/pata_parport/comm.c
@@ -206,16 +206,5 @@ static struct pi_protocol comm = {
        .log_adapter    = comm_log_adapter,
 };
 
-static int __init comm_init(void)
-{
-       return paride_register(&comm);
-}
-
-static void __exit comm_exit(void)
-{
-       paride_unregister(&comm);
-}
-
 MODULE_LICENSE("GPL");
-module_init(comm_init)
-module_exit(comm_exit)
+module_pata_parport_driver(comm);

diff --git a/drivers/ata/pata_parport/dstr.c b/drivers/ata/pata_parport/dstr.c
index edf414d186a6bd8b7baf6e98cb7955a23f1e127b..e733a2512e17bb2237ae8dff81af9ecce814c827 100644 (file)
--- a/drivers/ata/pata_parport/dstr.c
+++ b/drivers/ata/pata_parport/dstr.c
@@ -218,16 +218,5 @@ static struct pi_protocol dstr = {
        .log_adapter    = dstr_log_adapter,
 };
 
-static int __init dstr_init(void)
-{
-       return paride_register(&dstr);
-}
-
-static void __exit dstr_exit(void)
-{
-       paride_unregister(&dstr);
-}
-
 MODULE_LICENSE("GPL");
-module_init(dstr_init)
-module_exit(dstr_exit)
+module_pata_parport_driver(dstr);

diff --git a/drivers/ata/pata_parport/epat.c b/drivers/ata/pata_parport/epat.c
index 93ee91d9338b01447983803ccbf801c492b27837..7583d07083a8b9c06a4683b75c9133366575c7e7 100644 (file)
--- a/drivers/ata/pata_parport/epat.c
+++ b/drivers/ata/pata_parport/epat.c
@@ -327,12 +327,12 @@ static int __init epat_init(void)
 #ifdef CONFIG_PATA_PARPORT_EPATC8
        epatc8 = 1;
 #endif
-       return paride_register(&epat);
+       return pata_parport_register_driver(&epat);
 }
 
 static void __exit epat_exit(void)
 {
-       paride_unregister(&epat);
+       pata_parport_unregister_driver(&epat);
 }
 
 MODULE_LICENSE("GPL");

diff --git a/drivers/ata/pata_parport/epia.c b/drivers/ata/pata_parport/epia.c
index 417d5a3c7f720d76736e5090a901f0f86fd0aac7..2bcb18a6845aa21ad383db38b426a1b6e51733d3 100644 (file)
--- a/drivers/ata/pata_parport/epia.c
+++ b/drivers/ata/pata_parport/epia.c
@@ -301,16 +301,5 @@ static struct pi_protocol epia = {
        .log_adapter    = epia_log_adapter,
 };
 
-static int __init epia_init(void)
-{
-       return paride_register(&epia);
-}
-
-static void __exit epia_exit(void)
-{
-       paride_unregister(&epia);
-}
-
 MODULE_LICENSE("GPL");
-module_init(epia_init)
-module_exit(epia_exit)
+module_pata_parport_driver(epia);

diff --git a/drivers/ata/pata_parport/fit2.c b/drivers/ata/pata_parport/fit2.c
index 3c7a1069b026d319b0e1a98f9688e82dc4d5e08a..c63f0cd2ea52805dc8f6ee10a4ce4da3fe24ce02 100644 (file)
--- a/drivers/ata/pata_parport/fit2.c
+++ b/drivers/ata/pata_parport/fit2.c
@@ -136,16 +136,5 @@ static struct pi_protocol fit2 = {
        .log_adapter    = fit2_log_adapter,
 };
 
-static int __init fit2_init(void)
-{
-       return paride_register(&fit2);
-}
-
-static void __exit fit2_exit(void)
-{
-       paride_unregister(&fit2);
-}
-
 MODULE_LICENSE("GPL");
-module_init(fit2_init)
-module_exit(fit2_exit)
+module_pata_parport_driver(fit2);

diff --git a/drivers/ata/pata_parport/fit3.c b/drivers/ata/pata_parport/fit3.c
index cd95f4f0edc2df6f12af532867a03947fb89830b..adbef142c88fb8f3ab23538d9454e0fcdc5bd529 100644 (file)
--- a/drivers/ata/pata_parport/fit3.c
+++ b/drivers/ata/pata_parport/fit3.c
@@ -196,16 +196,5 @@ static struct pi_protocol fit3 = {
        .log_adapter    = fit3_log_adapter,
 };
 
-static int __init fit3_init(void)
-{
-       return paride_register(&fit3);
-}
-
-static void __exit fit3_exit(void)
-{
-       paride_unregister(&fit3);
-}
-
 MODULE_LICENSE("GPL");
-module_init(fit3_init)
-module_exit(fit3_exit)
+module_pata_parport_driver(fit3);

diff --git a/drivers/ata/pata_parport/friq.c b/drivers/ata/pata_parport/friq.c
index da1d0cb016d66735f749428fbd33ec6d41fffeb8..e740fe933e2049d8059e6c0061fce3430f61480a 100644 (file)
--- a/drivers/ata/pata_parport/friq.c
+++ b/drivers/ata/pata_parport/friq.c
@@ -261,16 +261,5 @@ static struct pi_protocol friq = {
        .release_proto  = friq_release_proto,
 };
 
-static int __init friq_init(void)
-{
-       return paride_register(&friq);
-}
-
-static void __exit friq_exit(void)
-{
-       paride_unregister(&friq);
-}
-
 MODULE_LICENSE("GPL");
-module_init(friq_init)
-module_exit(friq_exit)
+module_pata_parport_driver(friq);

diff --git a/drivers/ata/pata_parport/frpw.c b/drivers/ata/pata_parport/frpw.c
index 7bc8fa16d5d85c04bdadf23c88b52bb6e1c3ea4d..8c8681812bedabe71d4d6c34f1f26f477cf30da6 100644 (file)
--- a/drivers/ata/pata_parport/frpw.c
+++ b/drivers/ata/pata_parport/frpw.c
@@ -298,16 +298,5 @@ static struct pi_protocol frpw = {
        .log_adapter    = frpw_log_adapter,
 };
 
-static int __init frpw_init(void)
-{
-       return paride_register(&frpw);
-}
-
-static void __exit frpw_exit(void)
-{
-       paride_unregister(&frpw);
-}
-
 MODULE_LICENSE("GPL");
-module_init(frpw_init)
-module_exit(frpw_exit)
+module_pata_parport_driver(frpw);

diff --git a/drivers/ata/pata_parport/kbic.c b/drivers/ata/pata_parport/kbic.c
index 93430ca32a52c2c1da73d99f25f110b03bde0668..b120597043cccf04331b58dcfaad7e75fb32ef4d 100644 (file)
--- a/drivers/ata/pata_parport/kbic.c
+++ b/drivers/ata/pata_parport/kbic.c
@@ -288,19 +288,19 @@ static int __init kbic_init(void)
 {
        int rv;
 
-       rv = paride_register(&k951);
+       rv = pata_parport_register_driver(&k951);
        if (rv < 0)
                return rv;
-       rv = paride_register(&k971);
+       rv = pata_parport_register_driver(&k971);
        if (rv < 0)
-               paride_unregister(&k951);
+               pata_parport_unregister_driver(&k951);
        return rv;
 }
 
 static void __exit kbic_exit(void)
 {
-       paride_unregister(&k951);
-       paride_unregister(&k971);
+       pata_parport_unregister_driver(&k951);
+       pata_parport_unregister_driver(&k971);
 }
 
 MODULE_LICENSE("GPL");

diff --git a/drivers/ata/pata_parport/ktti.c b/drivers/ata/pata_parport/ktti.c
index fc4f707fed1f22ec22b40f8fd0b449d88f9ef243..15463cd18968290833db5f758b0cd83224e14fc1 100644 (file)
--- a/drivers/ata/pata_parport/ktti.c
+++ b/drivers/ata/pata_parport/ktti.c
@@ -113,16 +113,5 @@ static struct pi_protocol ktti = {
        .log_adapter    = ktti_log_adapter,
 };
 
-static int __init ktti_init(void)
-{
-       return paride_register(&ktti);
-}
-
-static void __exit ktti_exit(void)
-{
-       paride_unregister(&ktti);
-}
-
 MODULE_LICENSE("GPL");
-module_init(ktti_init)
-module_exit(ktti_exit)
+module_pata_parport_driver(ktti);

diff --git a/drivers/ata/pata_parport/on20.c b/drivers/ata/pata_parport/on20.c
index 995fc41e3122b07c87ff8945c20c7e2a4c1413ef..f2a601e7784200a59a4d4c5076662521c1cfa3d1 100644 (file)
--- a/drivers/ata/pata_parport/on20.c
+++ b/drivers/ata/pata_parport/on20.c
@@ -138,16 +138,5 @@ static struct pi_protocol on20 = {
        .log_adapter    = on20_log_adapter,
 };
 
-static int __init on20_init(void)
-{
-       return paride_register(&on20);
-}
-
-static void __exit on20_exit(void)
-{
-       paride_unregister(&on20);
-}
-
 MODULE_LICENSE("GPL");
-module_init(on20_init)
-module_exit(on20_exit)
+module_pata_parport_driver(on20);

diff --git a/drivers/ata/pata_parport/on26.c b/drivers/ata/pata_parport/on26.c
index 35f1c481a782f422af71e24489e062ce9bbbf7f0..66f04015f19a0c3bb9cfb0eac6be38673e3cdd06 100644 (file)
--- a/drivers/ata/pata_parport/on26.c
+++ b/drivers/ata/pata_parport/on26.c
@@ -304,16 +304,5 @@ static struct pi_protocol on26 = {
        .log_adapter    = on26_log_adapter,
 };
 
-static int __init on26_init(void)
-{
-       return paride_register(&on26);
-}
-
-static void __exit on26_exit(void)
-{
-       paride_unregister(&on26);
-}
-
 MODULE_LICENSE("GPL");
-module_init(on26_init)
-module_exit(on26_exit)
+module_pata_parport_driver(on26);

diff --git a/include/linux/pata_parport.h b/include/linux/pata_parport.h
index 458544fe5e6c30b848fd7296efdb21e4dbed0a5b..9614ce53470ace16744e04d077de227b0cd5ba96 100644 (file)
--- a/include/linux/pata_parport.h
+++ b/include/linux/pata_parport.h
@@ -87,8 +87,16 @@ struct pi_protocol {
 
 int pata_parport_register_driver(struct pi_protocol *pr);
 void pata_parport_unregister_driver(struct pi_protocol *pr);
-/* defines for old paride protocol modules */
-#define paride_register pata_parport_register_driver
-#define paride_unregister pata_parport_unregister_driver
+
+/**
+ * module_pata_parport_driver() - Helper macro for registering a pata_parport driver
+ * @__pi_protocol: pi_protocol struct
+ *
+ * Helper macro for pata_parport drivers which do not do anything special in module
+ * init/exit. This eliminates a lot of boilerplate. Each module may only
+ * use this macro once, and calling it replaces module_init() and module_exit()
+ */
+#define module_pata_parport_driver(__pi_protocol) \
+       module_driver(__pi_protocol, pata_parport_register_driver, pata_parport_unregister_driver)
 
 #endif /* LINUX_PATA_PARPORT_H */