net: fix incorrect access to pointer
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 15 Jul 2016 08:43:32 +0000 (10:43 +0200)
committerJason Wang <jasowang@redhat.com>
Mon, 18 Jul 2016 08:16:49 +0000 (16:16 +0800)
This is not dereferencing the pointer, and instead checking only
the value of the pointer.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
net/eth.c

index 95fe15c23fd03ddaf115a37d477dab8360cc78a7..c147c2ebb37d5474c035322d3d01867dce517ba2 100644 (file)
--- a/net/eth.c
+++ b/net/eth.c
@@ -211,7 +211,7 @@ void eth_get_protocols(const struct iovec *iov, int iovcnt,
                                      *l4hdr_off, sizeof(l4hdr_info->hdr.tcp),
                                      &l4hdr_info->hdr.tcp);
 
-            if (istcp) {
+            if (*istcp) {
                 *l5hdr_off = *l4hdr_off +
                     TCP_HEADER_DATA_OFFSET(&l4hdr_info->hdr.tcp);