perf test: Use skip in PERF_RECORD_*
authorIan Rogers <irogers@google.com>
Wed, 18 May 2022 04:20:27 +0000 (21:20 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 23 May 2022 13:05:07 +0000 (10:05 -0300)
Check if the error code is EACCES and make the test a skip with
a "permissions" skip reason if so.

Committer testing:

Before:

  $ perf test PERF_RECORD
    8: PERF_RECORD_* events & perf_sample fields            : FAILED!
  $

After:

  $ perf test PERF_RECORD
    8: PERF_RECORD_* events & perf_sample fields            : Skip (permissions)
  $

Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Carsten Haitzler <carsten.haitzler@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Marco Elver <elver@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Riccardo Mancini <rickyman7@gmail.com>
Cc: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20220518042027.836799-9-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/perf-record.c

index 6354465067b87e3ee88ccfa4cc62111598f013a6..6a001fcfed68e5172e9fcc817e3064fd761102b7 100644 (file)
@@ -330,7 +330,21 @@ found_exit:
 out_delete_evlist:
        evlist__delete(evlist);
 out:
-       return (err < 0 || errs > 0) ? -1 : 0;
+       if (err == -EACCES)
+               return TEST_SKIP;
+       if (err < 0)
+               return TEST_FAIL;
+       return TEST_OK;
 }
 
-DEFINE_SUITE("PERF_RECORD_* events & perf_sample fields", PERF_RECORD);
+static struct test_case tests__PERF_RECORD[] = {
+       TEST_CASE_REASON("PERF_RECORD_* events & perf_sample fields",
+                        PERF_RECORD,
+                        "permissions"),
+       {       .name = NULL, }
+};
+
+struct test_suite suite__PERF_RECORD = {
+       .desc = "PERF_RECORD_* events & perf_sample fields",
+       .test_cases = tests__PERF_RECORD,
+};