[media] v4l: mt9v032: Consider control initialization errors as fatal

The device requires control to be properly operated, they're not
optional.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
index 3793d317772b2fdc1e1ad0fd8845322b8fa78a7d..6d64e23b1f94a84fc58e251ca211fba712a290be 100644 (file)
--- a/drivers/media/i2c/mt9v032.c
+++ b/drivers/media/i2c/mt9v032.c
@@ -961,9 +961,12 @@ static int mt9v032_probe(struct i2c_client *client,
 
        mt9v032->subdev.ctrl_handler = &mt9v032->ctrls;
 
-       if (mt9v032->ctrls.error)
-               printk(KERN_INFO "%s: control initialization error %d\n",
-                      __func__, mt9v032->ctrls.error);
+       if (mt9v032->ctrls.error) {
+               dev_err(&client->dev, "control initialization error %d\n",
+                       mt9v032->ctrls.error);
+               ret = mt9v032->ctrls.error;
+               goto err;
+       }
 
        mt9v032->crop.left = MT9V032_COLUMN_START_DEF;
        mt9v032->crop.top = MT9V032_ROW_START_DEF;