selftest: tpm2: Add Client.__del__() to close /dev/tpm* handle
authorStefan Berger <stefanb@linux.ibm.com>
Tue, 20 Sep 2022 13:15:18 +0000 (09:15 -0400)
committerJarkko Sakkinen <jarkko@kernel.org>
Tue, 4 Oct 2022 21:25:56 +0000 (00:25 +0300)
The following output can bee seen when the test is executed:

  test_flush_context (tpm2_tests.SpaceTest) ... \
    /usr/lib64/python3.6/unittest/case.py:605: ResourceWarning: \
    unclosed file <_io.FileIO name='/dev/tpmrm0' mode='rb+' closefd=True>

An instance of Client does not implicitly close /dev/tpm* handle, once it
gets destroyed. Close the file handle in the class destructor
Client.__del__().

Fixes: 6ea3dfe1e0732 ("selftests: add TPM 2.0 tests")
Cc: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
tools/testing/selftests/tpm2/tpm2.py

index 057a4f49c79d963e0657088a10d09ec1baf31bd5..c7363c6764fc63fbcf8284cda88591b25f0010d1 100644 (file)
@@ -371,6 +371,10 @@ class Client:
             fcntl.fcntl(self.tpm, fcntl.F_SETFL, flags)
             self.tpm_poll = select.poll()
 
+    def __del__(self):
+        if self.tpm:
+            self.tpm.close()
+
     def close(self):
         self.tpm.close()