projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8e6a439
)
spi: axi-spi-engine: return void from spi_engine_compile_message()
author
David Lechner
<dlechner@baylibre.com>
Mon, 4 Dec 2023 17:33:27 +0000
(11:33 -0600)
committer
Mark Brown
<broonie@kernel.org>
Wed, 6 Dec 2023 14:19:29 +0000
(14:19 +0000)
In the AXI SPI Engine driver, the spi_engine_compile_message() function
does not return any error and none of the callers check the return
value. So we can change the return type to void and drop the return 0.
Signed-off-by: David Lechner <dlechner@baylibre.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Nuno Sa <nuno.sa@analog.com>
Link:
https://lore.kernel.org/r/20231204-axi-spi-engine-series-2-v1-1-063672323fce@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-axi-spi-engine.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-axi-spi-engine.c
b/drivers/spi/spi-axi-spi-engine.c
index cbca783830eaecb6a907de6207b463f0beb4e184..982b37ac3063adf00347b265a869e95077852ee7 100644
(file)
--- a/
drivers/spi/spi-axi-spi-engine.c
+++ b/
drivers/spi/spi-axi-spi-engine.c
@@
-218,7
+218,7
@@
static void spi_engine_gen_cs(struct spi_engine_program *p, bool dry,
spi_engine_program_add_cmd(p, dry, SPI_ENGINE_CMD_ASSERT(1, mask));
}
-static
int
spi_engine_compile_message(struct spi_engine *spi_engine,
+static
void
spi_engine_compile_message(struct spi_engine *spi_engine,
struct spi_message *msg, bool dry, struct spi_engine_program *p)
{
struct spi_device *spi = msg->spi;
@@
-273,8
+273,6
@@
static int spi_engine_compile_message(struct spi_engine *spi_engine,
if (!keep_cs)
spi_engine_gen_cs(p, dry, spi, false);
-
- return 0;
}
static void spi_engine_xfer_next(struct spi_message *msg,