pwm: pca9685: Reset OFF/ON registers to POR value
authorLionel Vitte <lionel.vitte@gmail.com>
Sat, 22 Jan 2022 06:58:19 +0000 (07:58 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 24 Feb 2022 13:01:18 +0000 (14:01 +0100)
During the driver probe, registers are not set to their POR value.

Signed-off-by: Lionel Vitte <lionel.vitte@free.fr>
Acked-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-pca9685.c

index c56001a790d0548078351ce32e19444e0083d93c..c91fa7f9e33da975a73407e9bd4eac28c4109cfe 100644 (file)
@@ -560,10 +560,10 @@ static int pca9685_pwm_probe(struct i2c_client *client,
        pca9685_write_reg(pca, PCA9685_MODE1, reg);
 
        /* Reset OFF/ON registers to POR default */
-       pca9685_write_reg(pca, PCA9685_ALL_LED_OFF_L, LED_FULL);
+       pca9685_write_reg(pca, PCA9685_ALL_LED_OFF_L, 0);
        pca9685_write_reg(pca, PCA9685_ALL_LED_OFF_H, LED_FULL);
        pca9685_write_reg(pca, PCA9685_ALL_LED_ON_L, 0);
-       pca9685_write_reg(pca, PCA9685_ALL_LED_ON_H, 0);
+       pca9685_write_reg(pca, PCA9685_ALL_LED_ON_H, LED_FULL);
 
        pca->chip.ops = &pca9685_pwm_ops;
        /* Add an extra channel for ALL_LED */