vhost scsi: fix error return code in vhost_scsi_set_endpoint()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607071411-33484-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 6ff8a509669154e04b4a8d1b85d99e2a586781a2..4ce9f00ae10e84ba7ad6272a37e0d29bd0671e9b 100644 (file)
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
                        if (!vhost_vq_is_setup(vq))
                                continue;
 
-                       if (vhost_scsi_setup_vq_cmds(vq, vq->num))
+                       ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
+                       if (ret)
                                goto destroy_vq_cmds;
                }