staging: r8188eu: convert GetHalDefVar8188EUsb() to void
authorMichael Straube <straube.linux@gmail.com>
Fri, 28 Jan 2022 11:54:43 +0000 (12:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Jan 2022 12:56:24 +0000 (13:56 +0100)
The return value of GetHalDefVar8188EUsb() is not used. Convert the
function to void.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220128115445.6606-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/hal_intf.h

index 87382806774b47dff868d3fb63dda839c977be24..7a640fbaaca63f8c469393c91fb03161a174cf6b 100644 (file)
@@ -1600,10 +1600,9 @@ void GetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
 }
 
 /* Query setting of specified variable. */
-u8 GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue)
+void GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue)
 {
        struct hal_data_8188e *haldata = &Adapter->haldata;
-       u8 bResult = _SUCCESS;
 
        switch (eVariable) {
        case HAL_DEF_UNDERCORATEDSMOOTHEDPWDB:
@@ -1647,11 +1646,8 @@ u8 GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariable
                *((u8 *)pValue) = haldata->bDumpTxPkt;
                break;
        default:
-               bResult = _FAIL;
                break;
        }
-
-       return bResult;
 }
 
 /* Change default setting of specified variable. */
index f382b7fefb4a61f1984cacc2d7ff1c67ce09c31f..96016e175cb547d492fbd44a1c53329adbd67a3c 100644 (file)
@@ -102,7 +102,7 @@ int rtl8188e_IOL_exec_cmds_sync(struct adapter *adapter,
                                struct xmit_frame *xmit_frame, u32 max_wating_ms, u32 bndy_cnt);
 
 u8 SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
-u8 GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
+void GetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
 
 unsigned int rtl8188eu_inirp_init(struct adapter *Adapter);