wifi: ath12k: dp_mon: Fix uninitialized warning related to the pktlog
authorThiraviyam Mariyappan <quic_tmariyap@quicinc.com>
Tue, 17 Jan 2023 12:03:19 +0000 (14:03 +0200)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 18 Jan 2023 06:37:56 +0000 (08:37 +0200)
Uninitialized warning in the code changes related to pktlog, which is not
completely supported in ath12k driver yet. Hence, remove the changes to
avoid the warning.

Warning:
drivers/net/wireless/ath/ath12k/dp_mon.c:2138:18: warning: variable 'rx_buf_sz' is uninitialized when used here [-Wuninitialized]

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0-03171-QCAHKSWPL_SILICONZ-1
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thiraviyam Mariyappan <quic_tmariyap@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20221221105529.19345-5-quic_tmariyap@quicinc.com
drivers/net/wireless/ath/ath12k/dp_mon.c

index f6f2e83f8f8e058e22b598daf4fd6908442b20e4..a214797c96a2db330c81548b6d381fa3f886e8b5 100644 (file)
@@ -2076,8 +2076,6 @@ int ath12k_dp_mon_srng_process(struct ath12k *ar, int mac_id, int *budget,
        bool end_of_ppdu;
        struct hal_rx_mon_ppdu_info *ppdu_info;
        struct ath12k_peer *peer = NULL;
-       u32 rx_buf_sz;
-       u16 log_type = 0;
 
        ppdu_info = &pmon->mon_ppdu_info;
        memset(ppdu_info, 0, sizeof(*ppdu_info));
@@ -2133,10 +2131,6 @@ int ath12k_dp_mon_srng_process(struct ath12k *ar, int mac_id, int *budget,
                for (i = 0; i < dest_idx; i++) {
                        skb = pmon->dest_skb_q[i];
 
-                       if (log_type)
-                               trace_ath12k_htt_rxdesc(ar, skb->data,
-                                                       log_type, rx_buf_sz);
-
                        if (monitor_mode == ATH12K_DP_RX_MONITOR_MODE)
                                ath12k_dp_mon_rx_parse_mon_status(ar, pmon, mac_id,
                                                                  skb, napi);