dma-buf: heaps: Fix the name used when exporting dmabufs to be the actual heap name
authorJohn Stultz <john.stultz@linaro.org>
Tue, 9 Feb 2021 19:48:18 +0000 (19:48 +0000)
committerSumit Semwal <sumit.semwal@linaro.org>
Thu, 25 Feb 2021 12:58:24 +0000 (18:28 +0530)
By default dma_buf_export() sets the exporter name to be
KBUILD_MODNAME. Unfortunately this may not be identical to the
string used as the heap name (ie: "system" vs "system_heap").

This can cause some minor confusion with tooling, and there is
the future potential where multiple heap types may be exported
by the same module (but would all have the same name).

So to avoid all this, set the exporter exp_name to the heap name.

Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Liam Mark <lmark@codeaurora.org>
Cc: Chris Goldsworthy <cgoldswo@codeaurora.org>
Cc: Laura Abbott <labbott@kernel.org>
Cc: Brian Starkey <Brian.Starkey@arm.com>
Cc: Hridya Valsaraju <hridya@google.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Sandeep Patil <sspatil@google.com>
Cc: Daniel Mentz <danielmentz@google.com>
Cc: Ørjan Eide <orjan.eide@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Simon Ser <contact@emersion.fr>
Cc: James Jones <jajones@nvidia.com>
Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: John Stultz <john.stultz@linaro.org>
Acked-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210209194818.2459062-2-john.stultz@linaro.org
drivers/dma-buf/heaps/cma_heap.c
drivers/dma-buf/heaps/system_heap.c

index 84c6cd1b96a9227229b528f59e3bd6c2af5a0066..40113381f53e2366ee0ebf71cdb8ec4e35dd95e3 100644 (file)
@@ -336,6 +336,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap,
        buffer->pagecount = pagecount;
 
        /* create the dmabuf */
+       exp_info.exp_name = dma_heap_get_name(heap);
        exp_info.ops = &cma_heap_buf_ops;
        exp_info.size = buffer->len;
        exp_info.flags = fd_flags;
index 29e49ac1725135ee6254ed9e0726e42bc885e7b3..23a7e74ef9666beb0b1a49471b4f658a849b235a 100644 (file)
@@ -390,6 +390,7 @@ static struct dma_buf *system_heap_allocate(struct dma_heap *heap,
        }
 
        /* create the dmabuf */
+       exp_info.exp_name = dma_heap_get_name(heap);
        exp_info.ops = &system_heap_buf_ops;
        exp_info.size = buffer->len;
        exp_info.flags = fd_flags;