drm/i915: Drop vma is-closed assertion on insert
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 3 Mar 2020 09:31:57 +0000 (09:31 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 3 Mar 2020 17:30:20 +0000 (17:30 +0000)
The is-closed flag may be added after we have acquired the vma under the
ctx->mutex, but will not take effect until after we release the
vm->mutex. i.e. the flag may be set on the vma as attempt to bind it and
that will cause the vma to be unbound later after we unpin it.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200303093157.1153887-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_vma.c

index 298ca4316e65428620822238e35f19daaaa47a37..3dde671145f7b3e8670d99fa91e4975552eff602 100644 (file)
@@ -641,7 +641,6 @@ i915_vma_insert(struct i915_vma *vma, u64 size, u64 alignment, u64 flags)
        u64 start, end;
        int ret;
 
-       GEM_BUG_ON(i915_vma_is_closed(vma));
        GEM_BUG_ON(i915_vma_is_bound(vma, I915_VMA_GLOBAL_BIND | I915_VMA_LOCAL_BIND));
        GEM_BUG_ON(drm_mm_node_allocated(&vma->node));