drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write()

If the kzalloc() fails then this code will crash.  Return -ENOMEM instead.

Fixes: e50d9ba0d2cd ("drm/amdgpu: Add debugfs TA load/unload/invoke support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c
index 32bcc20b9e3f78d60741aec7292e72874687312d..6806deb098d3f7d82be395e0fa7271c93485e7e3 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c
@@ -254,7 +254,7 @@ static ssize_t ta_if_invoke_debugfs_write(struct file *fp, const char *buf, size
 
        shared_buf = kzalloc(shared_buf_len, GFP_KERNEL);
        if (!shared_buf)
-               ret = -ENOMEM;
+               return -ENOMEM;
        if (copy_from_user((void *)shared_buf, &buf[copy_pos], shared_buf_len)) {
                ret = -EFAULT;
                goto err_free_shared_buf;