nbd/server: fix NBD_CMD_CACHE
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Wed, 3 Oct 2018 14:47:38 +0000 (17:47 +0300)
committerEric Blake <eblake@redhat.com>
Wed, 3 Oct 2018 14:58:43 +0000 (09:58 -0500)
We should not go to structured-read branch on CACHE command, fix that.

Bug introduced in bc37b06a5cde24 "nbd/server: introduce NBD_CMD_CACHE"
with the whole feature and affects 3.0.0 release.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
CC: qemu-stable@nongnu.org
Message-Id: <20181003144738.70670-1-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[eblake: commit message typo fix]
Signed-off-by: Eric Blake <eblake@redhat.com>
nbd/server.c

index 98d0fa25158366aa3c3699cfad75e3a9ab3c30bf..4fb247b11667eb744d12a348d2201f928fe2c618 100644 (file)
@@ -2177,7 +2177,8 @@ static coroutine_fn int nbd_do_cmd_read(NBDClient *client, NBDRequest *request,
     }
 
     if (client->structured_reply && !(request->flags & NBD_CMD_FLAG_DF) &&
-        request->len) {
+        request->len && request->type != NBD_CMD_CACHE)
+    {
         return nbd_co_send_sparse_read(client, request->handle, request->from,
                                        data, request->len, errp);
     }