fix

diff --git a/ChangeLog b/ChangeLog
index 814289ad0645cdc4a4e5ab0c91954afad68c1cc0..34a60097762732de83052f7ceb778317deeff5ac 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2005-03-18  Miklos Szeredi <miklos@szeredi.hu>
+
+       * kernel: fix bug which could cause leave busy inodes after
+       unmount, and Oops.
+
 2005-03-08  Miklos Szeredi <miklos@szeredi.hu>
 
        * Released 2.2.1

diff --git a/kernel/dev.c b/kernel/dev.c
index f3de9de71746cb2e25f0f00f1245d8686e753f6e..537c273b67259761ddf9257f9c8f5a0b215fff80 100644 (file)
--- a/kernel/dev.c
+++ b/kernel/dev.c
@@ -178,6 +178,17 @@ void fuse_put_request(struct fuse_conn *fc, struct fuse_req *req)
                fuse_putback_request(fc, req);
 }
 
+void fuse_release_background(struct fuse_req *req)
+{
+       if (req->inode)
+               iput(req->inode);
+       if (req->inode2)
+               iput(req->inode2);
+       if (req->file)
+               fput(req->file);
+       list_del(&req->bg_entry);
+}
+
 /* Called with fuse_lock, unlocks it */
 static void request_end(struct fuse_conn *fc, struct fuse_req *req)
 {
@@ -186,12 +197,10 @@ static void request_end(struct fuse_conn *fc, struct fuse_req *req)
        putback = atomic_dec_and_test(&req->count);
        spin_unlock(&fuse_lock);
        if (req->background) {
-               if (req->inode)
-                       iput(req->inode);
-               if (req->inode2)
-                       iput(req->inode2);
-               if (req->file)
-                       fput(req->file);
+               down_read(&fc->sbput_sem);
+               if (fc->sb)
+                       fuse_release_background(req);
+               up_read(&fc->sbput_sem);
        }
        wake_up(&req->waitq);
        if (req->in.h.opcode == FUSE_INIT) {
@@ -207,11 +216,12 @@ static void request_end(struct fuse_conn *fc, struct fuse_req *req)
                fuse_putback_request(fc, req);
 }
 
-static void background_request(struct fuse_req *req)
+static void background_request(struct fuse_conn *fc, struct fuse_req *req)
 {
        /* Need to get hold of the inode(s) and/or file used in the
           request, so FORGET and RELEASE are not sent too early */
        req->background = 1;
+       list_add(&req->bg_entry, &fc->background);
        if (req->inode)
                req->inode = igrab(req->inode);
        if (req->inode2)
@@ -231,7 +241,8 @@ static int request_wait_answer_nonint(struct fuse_req *req)
 }
 
 /* Called with fuse_lock held.  Releases, and then reacquires it. */
-static void request_wait_answer(struct fuse_req *req, int interruptible)
+static void request_wait_answer(struct fuse_conn *fc, struct fuse_req *req,
+                               int interruptible)
 {
        int intr;
 
@@ -271,7 +282,7 @@ static void request_wait_answer(struct fuse_req *req, int interruptible)
                list_del(&req->list);
                __fuse_put_request(req);
        } else if (!req->finished && req->sent)
-               background_request(req);
+               background_request(fc, req);
 }
 
 static unsigned len_args(unsigned numargs, struct fuse_arg *args)
@@ -315,7 +326,7 @@ static void request_send_wait(struct fuse_conn *fc, struct fuse_req *req,
                   after request_end() */
                __fuse_get_request(req);
 
-               request_wait_answer(req, interruptible);
+               request_wait_answer(fc, req, interruptible);
        }
        spin_unlock(&fuse_lock);
 }
@@ -351,7 +362,7 @@ void request_send_noreply(struct fuse_conn *fc, struct fuse_req *req)
 void request_send_background(struct fuse_conn *fc, struct fuse_req *req)
 {
        req->isreply = 1;
-       background_request(req);
+       background_request(fc, req);
        request_send_nowait(fc, req);
 }
 

diff --git a/kernel/fuse_i.h b/kernel/fuse_i.h
index 4aa643bdf5c84e129654d669bb65c97e0e8fcf43..0f671f285ddad40d86672eaa6595c6b5e4bb3e13 100644 (file)
--- a/kernel/fuse_i.h
+++ b/kernel/fuse_i.h
@@ -190,6 +190,9 @@ struct fuse_req {
            lists in fuse_conn */
        struct list_head list;
 
+       /** Entry on the background list */
+       struct list_head bg_entry;
+
        /** refcount */
        atomic_t count;
 
@@ -284,6 +287,10 @@ struct fuse_conn {
        /** The list of requests being processed */
        struct list_head processing;
 
+       /** Requests put in the background (RELEASE or any other
+           interrupted request) */
+       struct list_head background;
+
        /** Controls the maximum number of outstanding requests */
        struct semaphore outstanding_sem;
 
@@ -291,6 +298,9 @@ struct fuse_conn {
            outstanding_sem would go negative */
        unsigned outstanding_debt;
 
+       /** RW semaphore for exclusion with fuse_put_super() */
+       struct rw_semaphore sbput_sem;
+
        /** The list of unused requests */
        struct list_head unused_list;
 
@@ -488,6 +498,11 @@ void request_send_noreply(struct fuse_conn *fc, struct fuse_req *req);
  */
 void request_send_background(struct fuse_conn *fc, struct fuse_req *req);
 
+/**
+ * Release inodes and file assiciated with background request
+ */
+void fuse_release_background(struct fuse_req *req);
+
 /**
  * Get the attributes of a file
  */

diff --git a/kernel/inode.c b/kernel/inode.c
index d935d588f6133ddfc2d99c39f0dd601798b0e3d2..1feaba9ab1bb6251b5d63938245863f327242d02 100644 (file)
--- a/kernel/inode.c
+++ b/kernel/inode.c
@@ -100,7 +100,7 @@ void fuse_send_forget(struct fuse_conn *fc, struct fuse_req *req,
 static void fuse_clear_inode(struct inode *inode)
 {
        struct fuse_conn *fc = get_fuse_conn(inode);
-       if (fc) {
+       if (fc && (inode->i_sb->s_flags & MS_ACTIVE)) {
                struct fuse_inode *fi = get_fuse_inode(inode);
                fuse_send_forget(fc, fi->forget_req, fi->nodeid, inode->i_version);
                fi->forget_req = NULL;
@@ -254,12 +254,18 @@ static void fuse_put_super(struct super_block *sb)
 {
        struct fuse_conn *fc = get_fuse_conn_super(sb);
 
+       down_write(&fc->sbput_sem);
+       while (!list_empty(&fc->background))
+               fuse_release_background(list_entry(fc->background.next,
+                                                  struct fuse_req, bg_entry));
+
        spin_lock(&fuse_lock);
        fc->sb = NULL;
        fc->user_id = 0;
        fc->flags = 0;
        /* Flush all readers on this fs */
        wake_up_all(&fc->waitq);
+       up_write(&fc->sbput_sem);
        fuse_release_conn(fc);
        *get_fuse_conn_super_p(sb) = NULL;
        spin_unlock(&fuse_lock);
@@ -467,7 +473,9 @@ static struct fuse_conn *new_conn(void)
                INIT_LIST_HEAD(&fc->pending);
                INIT_LIST_HEAD(&fc->processing);
                INIT_LIST_HEAD(&fc->unused_list);
+               INIT_LIST_HEAD(&fc->background);
                sema_init(&fc->outstanding_sem, 0);
+               init_rwsem(&fc->sbput_sem);
                for (i = 0; i < FUSE_MAX_OUTSTANDING; i++) {
                        struct fuse_req *req = fuse_request_alloc();
                        if (!req) {