media: saa7134: use semicolons rather than commas to separate statements
authorJulia Lawall <Julia.Lawall@inria.fr>
Tue, 29 Sep 2020 13:14:27 +0000 (15:14 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:06 +0000 (10:31 +0100)
Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/saa7134/saa7134-video.c

index 94c1c10d0fead6963335057e00aac2ccca75ac93..c24716f4ce2367b63cf8020de14b13a03bf5827b 100644 (file)
@@ -868,8 +868,11 @@ static int buffer_activate(struct saa7134_dev *dev,
                lines_uv = dev->height >> dev->fmt->vshift;
                base2    = base + bpl * dev->height;
                base3    = base2 + bpl_uv * lines_uv;
-               if (dev->fmt->uvswap)
-                       tmp = base2, base2 = base3, base3 = tmp;
+               if (dev->fmt->uvswap) {
+                       tmp = base2;
+                       base2 = base3;
+                       base3 = tmp;
+               }
                video_dbg("uv: bpl=%ld lines=%ld base2/3=%ld/%ld\n",
                        bpl_uv,lines_uv,base2,base3);
                if (V4L2_FIELD_HAS_BOTH(dev->field)) {