thermal/drivers/mediatek/lvts_thermal: Fix error check in lvts_debugfs_init()
authorMinjie Du <duminjie@vivo.com>
Thu, 21 Sep 2023 09:10:50 +0000 (17:10 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Sun, 15 Oct 2023 21:40:10 +0000 (23:40 +0200)
debugfs_create_dir() function returns an error value embedded in
the pointer (PTR_ERR). Evaluate the return value using IS_ERR
rather than checking for NULL.

Signed-off-by: Minjie Du <duminjie@vivo.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230921091057.3812-1-duminjie@vivo.com
drivers/thermal/mediatek/lvts_thermal.c

index f1feaa1ace2e02d75eed7dc429d5500b925abe08..704b22d12e274e29846201f7bf59ba54005ee3dd 100644 (file)
@@ -219,7 +219,7 @@ static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td)
 
                sprintf(name, "controller%d", i);
                dentry = debugfs_create_dir(name, lvts_td->dom_dentry);
-               if (!dentry)
+               if (IS_ERR(dentry))
                        continue;
 
                regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL);