habanalabs: Fix an error handling path in 'hl_pci_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 12 Jun 2021 05:39:51 +0000 (07:39 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Fri, 18 Jun 2021 12:23:42 +0000 (15:23 +0300)
If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: 2e5eda4681f9 ("habanalabs: PCIe Advanced Error Reporting support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/habanalabs_drv.c

index 3a4233971f2b363b142e4f4520511a230c5ba0ca..4d377a39df1312ccf706d5d0cfe62ddefee3b0be 100644 (file)
@@ -468,6 +468,7 @@ static int hl_pci_probe(struct pci_dev *pdev,
        return 0;
 
 disable_device:
+       pci_disable_pcie_error_reporting(pdev);
        pci_set_drvdata(pdev, NULL);
        destroy_hdev(hdev);