selftests: vm: Fix resource leak when return error
authorDing Xiang <dingxiang@cmss.chinamobile.com>
Wed, 15 Jun 2022 09:36:29 +0000 (17:36 +0800)
committerShuah Khan <skhan@linuxfoundation.org>
Thu, 16 Jun 2022 20:14:08 +0000 (14:14 -0600)
When return on an error path, file handle need to be closed
to prevent resource leak

Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/vm/ksm_tests.c

index 2fcf24312da887130afe8d46d5332e5e9a0e8b0e..f5e4e0bbd081534b8e17bc3e936e198970e78c16 100644 (file)
@@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val)
        }
        if (fprintf(f, "%lu", val) < 0) {
                perror("fprintf");
+               fclose(f);
                return 1;
        }
        fclose(f);
@@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val)
        }
        if (fscanf(f, "%lu", val) != 1) {
                perror("fscanf");
+               fclose(f);
                return 1;
        }
        fclose(f);