i40e: Add appropriate error message logged for incorrect duplex setting
authorAlicja Kowalska <alicjax.kowalska@intel.com>
Thu, 8 Sep 2022 08:07:10 +0000 (10:07 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 2 Nov 2022 16:26:18 +0000 (09:26 -0700)
Nothing logged in dmesg for attempting to set incorrect duplex.
Add appropriate error message logged for incorrect duplex setting.

Signed-off-by: Alicja Kowalska <alicjax.kowalska@intel.com>
Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/i40e/i40e_ethtool.c

index cc269f9db99f338ba49cbed3982fc3922ebc2a01..616d27ec3226354a37cd705079e3717e9b634d00 100644 (file)
@@ -1287,8 +1287,10 @@ static int i40e_set_link_ksettings(struct net_device *netdev,
         * trying to set something that we do not support.
         */
        if (memcmp(&copy_ks.base, &safe_ks.base,
-                  sizeof(struct ethtool_link_settings)))
+                  sizeof(struct ethtool_link_settings))) {
+               netdev_err(netdev, "Only speed and autoneg are supported.\n");
                return -EOPNOTSUPP;
+       }
 
        while (test_and_set_bit(__I40E_CONFIG_BUSY, pf->state)) {
                timeout--;