bus: mhi: ep: Add checks for read/write callbacks while registering controllers
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Mon, 27 Nov 2023 11:22:07 +0000 (16:52 +0530)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 15 Dec 2023 08:50:13 +0000 (14:20 +0530)
The MHI EP controller drivers has to support both sync and async read/write
callbacks. Hence, add a check for it.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/ep/main.c

index 063c07241da786458d28ea29d548754c332f5ed2..65fc1d738bec2671b6f0d08fb30e714c81df1167 100644 (file)
@@ -1464,6 +1464,10 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
        if (!mhi_cntrl || !mhi_cntrl->cntrl_dev || !mhi_cntrl->mmio || !mhi_cntrl->irq)
                return -EINVAL;
 
+       if (!mhi_cntrl->read_sync || !mhi_cntrl->write_sync ||
+           !mhi_cntrl->read_async || !mhi_cntrl->write_async)
+               return -EINVAL;
+
        ret = mhi_ep_chan_init(mhi_cntrl, config);
        if (ret)
                return ret;