usb: misc: ljca: Drop _ADR support to get ljca children devices
authorWentong Wu <wentong.wu@intel.com>
Tue, 14 Nov 2023 07:25:31 +0000 (15:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Nov 2023 14:30:10 +0000 (15:30 +0100)
Currently the shipped platforms use only _HID to distinguish
ljca children devices. The _ADR support here is for future HW.
This patch is to drop _ADR support and we can then re-introduce
it (revert this patch) if future HW actually starts using _ADR
to distinguish children devices.

Signed-off-by: Wentong Wu <wentong.wu@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231114072531.1366753-1-wentong.wu@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/usb-ljca.c

index c9decd0396d4990db1c8f1d2d01e157636f416a1..7f0deebebc130c9b416a9ddf3c97dfc1129787b0 100644 (file)
@@ -457,8 +457,8 @@ static void ljca_auxdev_acpi_bind(struct ljca_adapter *adap,
                                  u64 adr, u8 id)
 {
        struct ljca_match_ids_walk_data wd = { 0 };
-       struct acpi_device *parent, *adev;
        struct device *dev = adap->dev;
+       struct acpi_device *parent;
        char uid[4];
 
        parent = ACPI_COMPANION(dev);
@@ -466,17 +466,7 @@ static void ljca_auxdev_acpi_bind(struct ljca_adapter *adap,
                return;
 
        /*
-        * get auxdev ACPI handle from the ACPI device directly
-        * under the parent that matches _ADR.
-        */
-       adev = acpi_find_child_device(parent, adr, false);
-       if (adev) {
-               ACPI_COMPANION_SET(&auxdev->dev, adev);
-               return;
-       }
-
-       /*
-        * _ADR is a grey area in the ACPI specification, some
+        * Currently LJCA hw doesn't use _ADR instead the shipped
         * platforms use _HID to distinguish children devices.
         */
        switch (adr) {