drm/i915/dsc: Fix pic_width readout
authorSuraj Kandpal <suraj.kandpal@intel.com>
Mon, 11 Sep 2023 19:37:43 +0000 (01:07 +0530)
committerAnimesh Manna <animesh.manna@intel.com>
Thu, 14 Sep 2023 09:30:19 +0000 (15:00 +0530)
pic_width when written into the PPS register is divided by the no.
of vdsc instances first but the actual variable that we compare it
to does not change i.e vdsc_cfg->pic_width hence when reading the
register back for pic_width it needs to be multiplied by
num_vdsc_instances rather than being divided.

Fixes: 8b70b5691704 ("drm/i915/vdsc: Fill the intel_dsc_get_pps_config function")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230911193742.836063-1-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/intel_vdsc.c

index 5c00f7ccad7f95adea91b8af480959c5c9b3e819..6757dbae9ee5e9bf0f374cff5a68634b2ce0b0e3 100644 (file)
@@ -879,7 +879,7 @@ static void intel_dsc_get_pps_config(struct intel_crtc_state *crtc_state)
        /* PPS 2 */
        pps_temp = intel_dsc_pps_read_and_verify(crtc_state, 2);
 
-       vdsc_cfg->pic_width = REG_FIELD_GET(DSC_PPS2_PIC_WIDTH_MASK, pps_temp) / num_vdsc_instances;
+       vdsc_cfg->pic_width = REG_FIELD_GET(DSC_PPS2_PIC_WIDTH_MASK, pps_temp) * num_vdsc_instances;
        vdsc_cfg->pic_height = REG_FIELD_GET(DSC_PPS2_PIC_HEIGHT_MASK, pps_temp);
 
        /* PPS 3 */