staging: vc04_services: remove redundant assignment to pointer service
authorColin Ian King <colin.king@canonical.com>
Fri, 31 May 2019 13:39:26 +0000 (14:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2019 12:14:55 +0000 (14:14 +0200)
Pointer service is being set to NULL however this value is never
read and so the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c

index 13910d205fce2bda7fa05d6287c2053fe35824fd..17a4f2c8d8b1af3b8779d06f5f9e6ed5bff9764e 100644 (file)
@@ -639,10 +639,8 @@ int32_t vchi_service_close(const VCHI_SERVICE_HANDLE_T handle)
 
        if (service) {
                VCHIQ_STATUS_T status = vchiq_close_service(service->handle);
-               if (status == VCHIQ_SUCCESS) {
+               if (status == VCHIQ_SUCCESS)
                        service_free(service);
-                       service = NULL;
-               }
 
                ret = vchiq_status_to_vchi(status);
        }