PCI: Avoid potential out-of-bounds read in pci_dev_for_each_resource()

Coverity complains that pointer in the pci_dev_for_each_resource() may be
wrong, i.e., might be used for the out-of-bounds read.

There is no actual issue right now because we have another check afterwards
and the out-of-bounds read is not being performed. In any case it's better
code with this fixed, hence the proposed change.

As Jonas pointed out "It probably makes the code slightly less performant
as res will now be checked for being not NULL (which will always be true),
but I doubt it will be significant (or in any hot paths)."

Fixes: 09cc90063240 ("PCI: Introduce pci_dev_for_each_resource()")
Reported-by: Bjorn Helgaas <bhelgaas@google.com>
Closes: https://lore.kernel.org/r/20230509182122.GA1259567@bhelgaas
Suggested-by: Jonas Gorski <jonas.gorski@gmail.com>
Link: https://lore.kernel.org/r/20231030114218.2752236-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

diff --git a/include/linux/pci.h b/include/linux/pci.h
index 60ca768bc8679f4ff135f2d0364e46b5e7ab4fb9..4ebecc7896ef91993a7b8016d3bcab363a4eeb54 100644 (file)
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -2127,14 +2127,14 @@ int pci_iobar_pfn(struct pci_dev *pdev, int bar, struct vm_area_struct *vma);
        (pci_resource_end((dev), (bar)) ?                               \
         resource_size(pci_resource_n((dev), (bar))) : 0)
 
-#define __pci_dev_for_each_res0(dev, res, ...)                         \
-       for (unsigned int __b = 0;                                      \
-            res = pci_resource_n(dev, __b), __b < PCI_NUM_RESOURCES;   \
+#define __pci_dev_for_each_res0(dev, res, ...)                           \
+       for (unsigned int __b = 0;                                        \
+            __b < PCI_NUM_RESOURCES && (res = pci_resource_n(dev, __b)); \
             __b++)
 
-#define __pci_dev_for_each_res1(dev, res, __b)                         \
-       for (__b = 0;                                                   \
-            res = pci_resource_n(dev, __b), __b < PCI_NUM_RESOURCES;   \
+#define __pci_dev_for_each_res1(dev, res, __b)                           \
+       for (__b = 0;                                                     \
+            __b < PCI_NUM_RESOURCES && (res = pci_resource_n(dev, __b)); \
             __b++)
 
 #define pci_dev_for_each_resource(dev, res, ...)                       \