Revert "drm/udl: Add ARGB8888 as a format"
authorDouglas Anderson <dianders@chromium.org>
Wed, 6 Mar 2024 14:37:22 +0000 (06:37 -0800)
committerDouglas Anderson <dianders@chromium.org>
Wed, 6 Mar 2024 15:08:24 +0000 (07:08 -0800)
This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475.

Apparently there was a previous discussion about emulation of formats
and it was decided XRGB8888 was the only format to support for legacy
userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept
XRGB8888.

[1] https://lore.kernel.org/r/60dc7697-d7a0-4bf4-a22e-32f1bbb792c2@suse.de

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240306063721.1.I4a32475190334e1fa4eef4700ecd2787a43c94b5@changeid
drivers/gpu/drm/udl/udl_modeset.c

index 0f8d3678770e68a5fa0c03ed4d36d265060ed733..7702359c90c22594666347b6cc9d271db01df4bd 100644 (file)
@@ -253,7 +253,6 @@ static int udl_handle_damage(struct drm_framebuffer *fb,
 static const uint32_t udl_primary_plane_formats[] = {
        DRM_FORMAT_RGB565,
        DRM_FORMAT_XRGB8888,
-       DRM_FORMAT_ARGB8888,
 };
 
 static const uint64_t udl_primary_plane_fmtmods[] = {