remoteproc: qcom_q6v5_mss: Add MBA log extraction support

On SC7180 the MBA firmware stores the bootup text logs in a 4K segment
at the beginning of the MBA region. Add support to extract the logs
which will be useful to debug mba boot/authentication issues.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Link: https://lore.kernel.org/r/20200721112935.25716-3-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index a3c412a3f14341a062e30f6e52b5cb34e213fa0d..03d7f3d702b3a938388a18200fdd5b602051a03f 100644 (file)
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -9,6 +9,7 @@
 
 #include <linux/clk.h>
 #include <linux/delay.h>
+#include <linux/devcoredump.h>
 #include <linux/dma-mapping.h>
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
@@ -36,6 +37,8 @@
 
 #define MPSS_CRASH_REASON_SMEM         421
 
+#define MBA_LOG_SIZE                   SZ_4K
+
 /* RMB Status Register Values */
 #define RMB_PBL_SUCCESS                        0x1
 
@@ -138,6 +141,7 @@ struct rproc_hexagon_res {
        int version;
        bool need_mem_protection;
        bool has_alt_reset;
+       bool has_mba_logs;
        bool has_spare_reg;
 };
 
@@ -198,6 +202,7 @@ struct q6v5 {
        struct qcom_sysmon *sysmon;
        bool need_mem_protection;
        bool has_alt_reset;
+       bool has_mba_logs;
        bool has_spare_reg;
        int mpss_perm;
        int mba_perm;
@@ -509,6 +514,26 @@ static int q6v5_rmb_mba_wait(struct q6v5 *qproc, u32 status, int ms)
        return val;
 }
 
+static void q6v5_dump_mba_logs(struct q6v5 *qproc)
+{
+       struct rproc *rproc = qproc->rproc;
+       void *data;
+
+       if (!qproc->has_mba_logs)
+               return;
+
+       if (q6v5_xfer_mem_ownership(qproc, &qproc->mba_perm, true, false, qproc->mba_phys,
+                                   qproc->mba_size))
+               return;
+
+       data = vmalloc(MBA_LOG_SIZE);
+       if (!data)
+               return;
+
+       memcpy(data, qproc->mba_region, MBA_LOG_SIZE);
+       dev_coredumpv(&rproc->dev, data, MBA_LOG_SIZE, GFP_KERNEL);
+}
+
 static int q6v5proc_reset(struct q6v5 *qproc)
 {
        u32 val;
@@ -829,6 +854,7 @@ static int q6v5_mba_load(struct q6v5 *qproc)
 {
        int ret;
        int xfermemop_ret;
+       bool mba_load_err = false;
 
        qcom_q6v5_prepare(&qproc->q6v5);
 
@@ -918,7 +944,7 @@ halt_axi_ports:
        q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_q6);
        q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_modem);
        q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_nc);
-
+       mba_load_err = true;
 reclaim_mba:
        xfermemop_ret = q6v5_xfer_mem_ownership(qproc, &qproc->mba_perm, true,
                                                false, qproc->mba_phys,
@@ -926,6 +952,8 @@ reclaim_mba:
        if (xfermemop_ret) {
                dev_err(qproc->dev,
                        "Failed to reclaim mba buffer, system may become unstable\n");
+       } else if (mba_load_err) {
+               q6v5_dump_mba_logs(qproc);
        }
 
 disable_active_clks:
@@ -1283,6 +1311,7 @@ static int q6v5_start(struct rproc *rproc)
 
 reclaim_mpss:
        q6v5_mba_reclaim(qproc);
+       q6v5_dump_mba_logs(qproc);
 
        return ret;
 }
@@ -1702,6 +1731,7 @@ static int q6v5_probe(struct platform_device *pdev)
 
        qproc->version = desc->version;
        qproc->need_mem_protection = desc->need_mem_protection;
+       qproc->has_mba_logs = desc->has_mba_logs;
 
        ret = qcom_q6v5_init(&qproc->q6v5, pdev, rproc, MPSS_CRASH_REASON_SMEM,
                             qcom_msa_handover);
@@ -1793,6 +1823,7 @@ static const struct rproc_hexagon_res sc7180_mss = {
        },
        .need_mem_protection = true,
        .has_alt_reset = false,
+       .has_mba_logs = true,
        .has_spare_reg = true,
        .version = MSS_SC7180,
 };
@@ -1828,6 +1859,7 @@ static const struct rproc_hexagon_res sdm845_mss = {
        },
        .need_mem_protection = true,
        .has_alt_reset = true,
+       .has_mba_logs = false,
        .has_spare_reg = false,
        .version = MSS_SDM845,
 };
@@ -1855,6 +1887,7 @@ static const struct rproc_hexagon_res msm8998_mss = {
        },
        .need_mem_protection = true,
        .has_alt_reset = false,
+       .has_mba_logs = false,
        .has_spare_reg = false,
        .version = MSS_MSM8998,
 };
@@ -1885,6 +1918,7 @@ static const struct rproc_hexagon_res msm8996_mss = {
        },
        .need_mem_protection = true,
        .has_alt_reset = false,
+       .has_mba_logs = false,
        .has_spare_reg = false,
        .version = MSS_MSM8996,
 };
@@ -1918,6 +1952,7 @@ static const struct rproc_hexagon_res msm8916_mss = {
        },
        .need_mem_protection = false,
        .has_alt_reset = false,
+       .has_mba_logs = false,
        .has_spare_reg = false,
        .version = MSS_MSM8916,
 };
@@ -1959,6 +1994,7 @@ static const struct rproc_hexagon_res msm8974_mss = {
        },
        .need_mem_protection = false,
        .has_alt_reset = false,
+       .has_mba_logs = false,
        .has_spare_reg = false,
        .version = MSS_MSM8974,
 };