hwrng: stm32 - use logical OR in conditional
authorMarek Vasut <marex@denx.de>
Fri, 19 Apr 2024 05:01:12 +0000 (07:01 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 26 Apr 2024 09:26:09 +0000 (17:26 +0800)
The conditional is used to check whether err is non-zero OR whether
reg variable is non-zero after clearing bits from it. This should be
done using logical OR, not bitwise OR, fix it.

Fixes: 6b85a7e141cb ("hwrng: stm32 - implement STM32MP13x support")
Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/stm32-rng.c

index 379bc245c52022a9f0a6d081baa02a345750486f..1cc61ef8ee54c92449bcf43a793bb5cd15a5b98d 100644 (file)
@@ -353,7 +353,7 @@ static int stm32_rng_init(struct hwrng *rng)
        err = readl_relaxed_poll_timeout_atomic(priv->base + RNG_SR, reg,
                                                reg & RNG_SR_DRDY,
                                                10, 100000);
-       if (err | (reg & ~RNG_SR_DRDY)) {
+       if (err || (reg & ~RNG_SR_DRDY)) {
                clk_disable_unprepare(priv->clk);
                dev_err((struct device *)priv->rng.priv,
                        "%s: timeout:%x SR: %x!\n", __func__, err, reg);